[feat] Add defineMarker() for custom markers for selector combinators #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmn
requested review from
Jta26,
ezzak,
mellyeliu,
necolas and
vincentriemer
as code owners
meta-cla
bot
added
the
CLA Signed
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
nmn
force-pushed
the
feat/define-marker
branch
from
41ed47a to
9515085
Compare
nmn
force-pushed
the
feat/descendent-sibling
branch
from
8258f31 to
3b6d7b0
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
9515085 to
c97a6f4
Compare
nmn
force-pushed
the
feat/descendent-sibling
branch
from
2c942f8 to
e84cf6a
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
c97a6f4 to
bc7e57a
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
bc7e57a to
b5b2393
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
b5b2393 to
487f5d6
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
487f5d6 to
7ddc5b7
Compare
nmn
force-pushed
the
feat/define-marker
branch
from
7ddc5b7 to
ccc164a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The previous PR adds support for descendent/sibling selectors but only with a defaultMarker. That works for many common cases, but sometimes more that one marker is needed to differentiate between two ancestors, or two siblings etc.
This PR adds an API for defining custom markers with the
defineMarkerAPI.Additional Context
Needs a little more testing to build confidence. The same value needs to be both a string and an object in different situations, so we need to be a bit careful.
Pre-flight checklist
Contribution Guidelines